Repository navigation
fix(memory): accept PostgreSQL host:port configuration - #1191
Merged
yaozheng-fang merged 1 commit intoOct 28, 2026
Merged
Conversation
yaozheng-fang
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept PostgreSQL hosts such as
db.example.test:6543without appending the separately configured port a second time. The embedded port takes precedence; a plain hostname continues to useDATABASE_POSTGRESQL_PORT(default5432). Reject empty hostnames and embedded ports that are not ASCII decimal integers in1..65535, before creating the session service.The change is limited to the PostgreSQL backend and 26 regression cases. Both driver branches share the parsing, and explicit
db_urlhandling is unchanged. Only single-colon endpoints receive the new handling; this does not add IPv6 parsing.Validation on 2026-10-28, diff at
5647ed15:uv run --extra dev pytest tests/memory/test_postgres_endpoint.py tests/memory/test_postgres_schema.py tests/test_adk_compat.py -q --tb=short— 47 passed. The new regression cases were also exercised before the fix and reproduced the duplicate-port failure.uv run --extra dev pre-commit run --all-files— Ruff, formatting, secret scans, and dependency policy.llama_index,openai_codex, andanthropic. A subsequent retry of those modules plus the affected tests had 173 passed and 2 collection errors foranthropic. CI remains the full-suite gate; no live database was used.