Add support for huggingface datasets to vortex-python - #8733
Merged
Conversation
Merging this PR will not alter performance
|
Signed-off-by: Robert Kruszewski <github@robertk.io>
joseph-isaacs
approved these changes
Jul 29, 2026
robert3005
pushed a commit
that referenced
this pull request
Jul 29, 2026
Resolves the modify/delete conflict on vortex-python's registry.rs: this branch hoists that file into vortex-io, while #8733 fixed a percent-encoding bug in it on develop. Keeps the deletion and ports the fix into the hoisted registry: - `resolve` saturates the segment-count subtraction. A percent-encoded segment (`refs%2Fconvert%2Fparquet`) counts as one raw URL segment but decodes to three, so the subtraction underflowed and panicked. - `path_suffix` joins the segments and percent-decodes them through `Path::from_url_path` instead of `PathPart::parse` per segment. - Adds the regression test, using the injected `EnvSource` rather than the process environment. Signed-off-by: "Claude" <robert@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IterableDataset implementation backed by vortex files. Majority of the logic in this pr deal with adapting hugging face options into compatible vortex options