Skip to content

New C++ API tests#8751

Open
myrrc wants to merge 1 commit into
developfrom
myrrc/cxx2-tests
Open

New C++ API tests#8751
myrrc wants to merge 1 commit into
developfrom
myrrc/cxx2-tests

Conversation

@myrrc

@myrrc myrrc commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
  • Add tests for new C++ API.
  • Upload test results to codecov.
  • Make vx_array_new_primitive return an error on validity dtype/length mismatch

@myrrc myrrc added the changelog/feature A new feature label Jul 14, 2026
@myrrc myrrc marked this pull request as draft July 14, 2026 10:49
@myrrc myrrc force-pushed the myrrc/cxx2-tests branch 2 times, most recently from 2f72034 to f0a7082 Compare July 14, 2026 16:20
@myrrc myrrc marked this pull request as ready for review July 14, 2026 16:20
@myrrc myrrc requested a review from 0ax1 July 14, 2026 16:21
@myrrc myrrc added the lang/cpp Relates to the Vortex C++ API label Jul 14, 2026
@myrrc myrrc force-pushed the myrrc/cxx2-tests branch 3 times, most recently from de8b0dd to 34b5a3d Compare July 14, 2026 17:04
@myrrc myrrc enabled auto-merge (squash) July 14, 2026 17:27
Comment thread .github/workflows/rust-instrumented.yml
Comment thread .github/workflows/rust-instrumented.yml
Comment thread lang/cpp/include/vortex/scan.hpp
Comment thread lang/cpp/include/vortex/array.hpp
Comment thread lang/cpp/include/vortex/writer.hpp
Comment thread lang/cpp/tests/session.cpp Outdated
Comment thread lang/cpp/tests/array.cpp
Comment thread lang/cpp/include/vortex/common.hpp Outdated

namespace {
TEST_CASE("float16_t to_float (compatibility)", "[float]") {
REQUIRE(float(float16_t {0x3C00}) == 1.0F);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use a bit more coverage here.

Comment thread lang/cpp/tests/session.cpp Outdated
Comment thread lang/cpp/tests/float16_t.cpp Outdated
Comment thread lang/cpp/src/array.cpp
Comment thread lang/cpp/gcov-report.sh Outdated
Comment thread lang/cpp/gcov-report.sh
Comment thread lang/cpp/gcov-report.sh Outdated
Comment thread lang/cpp/src/array.cpp Outdated
Comment thread lang/cpp/src/writer.cpp
Comment thread lang/cpp/src/array.cpp Outdated
Comment thread lang/cpp/gcov-report.sh Outdated
Comment thread lang/cpp/gcov-report.sh Outdated
Comment thread lang/cpp/CMakeLists.txt
@myrrc myrrc requested a review from 0ax1 July 15, 2026 16:27
@myrrc myrrc force-pushed the myrrc/cxx2-tests branch from e2c5db4 to 4a765af Compare July 15, 2026 16:27
@myrrc myrrc disabled auto-merge July 15, 2026 16:33
@myrrc myrrc mentioned this pull request Jul 15, 2026
4 tasks
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/cxx2-tests branch from 4a765af to aa7d5a0 Compare July 15, 2026 16:47
@myrrc myrrc enabled auto-merge (squash) July 15, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature lang/cpp Relates to the Vortex C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants