non_nan_check doesn't try to cast arbitrary scalars to primitive

[robert3005]

non_nan_check tried to unconditionally cast Scalar to PrimitiveScalar - these
methods are error producing but in this case we never care about error and want
to ignore those cases. It's cheaper to directly check dtype for float type

[github-actions]

Polar Signals Profiling Results

Latest Run

Status	Commit	Job	Attempt	Link
🟢 Done	0086542		1	Explore Profiling Data

---

Powered by Polar Signals Cloud

[github-actions]

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +0.4%
Engines: DataFusion No clear signal (-1.7%, low confidence) · DuckDB No clear signal (+2.5%, low confidence)
Vortex (geomean): 0.972x ➖
Parquet (geomean): 0.970x ➖
Shifts: Parquet (control) -3.0% · Median polish -3.0%

How to read Verdict and Engines

• Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
• Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
• Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

---

datafusion / vortex-file-compressed (0.930x ➖, 0↑ 0↓)

name	PR 0086542 (ns)	base 5e8917c (ns)	ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed	9932950	10381533	0.96
vortex_q01/datafusion:vortex-file-compressed	6200217	6857576	0.90

datafusion / parquet (0.947x ➖, 0↑ 0↓)

name	PR 0086542 (ns)	base 5e8917c (ns)	ratio (PR/base)
vortex_q00/datafusion:parquet	20584810	21125211	0.97
vortex_q01/datafusion:parquet	4810870	5231260	0.92

duckdb / vortex-file-compressed (1.019x ➖, 0↑ 0↓)

name	PR 0086542 (ns)	base 5e8917c (ns)	ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed	10114747	10147371	1.00
vortex_q01/duckdb:vortex-file-compressed	6148375	5904015	1.04

duckdb / parquet (0.994x ➖, 0↑ 0↓)

name	PR 0086542 (ns)	base 5e8917c (ns)	ratio (PR/base)
vortex_q00/duckdb:parquet	23496777	23924449	0.98
vortex_q01/duckdb:parquet	9383100	9335080	1.01

---

No file size changes detected.