Fix/ssh connection#3348
Conversation
* fix: copy-on-select overwrites clipboard when search is open (#1) Change the guard in termwrap.ts from checking focused element (document.activeElement.closest) to checking DOM presence (document.querySelector) to prevent copy-on-select from firing whenever search is open, regardless of focus state. * chore: mark verification tasks complete, archive openspec change, sync specs
WaveTerm previously ignored the ProxyCommand directive in ~/.ssh/config, causing connections via SSH config Host entries with ProxyCommand to fail with 'Disconnected from xxx'. This change: - Parses ProxyCommand from SSH config in findSshConfigKeywords - Executes the proxy command via os/exec with %h/%p/%r expansion - Wraps command stdin/stdout as net.Conn via net.Pipe() - Cleans up the subprocess on connection close via proxyCommandConn Affects: pkg/wconfig/settingsconfig.go, pkg/remote/sshclient.go, frontend/types/gotypes.d.ts
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (52)
WalkthroughThis PR introduces four major feature areas: comprehensive OpenSpec workflow documentation (for apply, archive, explore, and propose operations), Playwright-based Electron E2E testing infrastructure with a clipboard-preservation test, a fix for copy-on-select behavior when the terminal search UI is active, and SSH ProxyCommand support for SSH connections. It also adds project documentation and minor infrastructure updates. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
|
|
2 participants
No description provided.