Skip to content

fix(config): read the HFresh multivector config, widen shard statuses, test against 1.40 - #2190

Open
g-despot wants to merge 5 commits into
mainfrom
fix/hfresh-multivector-read-and-1-40-matrix
Open

g-despot wants to merge 5 commits into
mainfrom
fix/hfresh-multivector-read-and-1-40-matrix

Conversation

@g-despot

@g-despot g-despot commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Fix. config.get() returned multi_vector=None for every HFresh index because the HFresh reader hardcoded it. It now parses the server's multivector block with the same helper the HNSW and flat readers use, so MUVERA settings round-trip. Verified live against 1.40.0: _MultiVectorConfig(encoding=_MuveraConfig(enabled=True, ksim=4, dprojections=16, repetitions=10)), and a plain HFresh vector still reads back None.

Typing. ShardTypes lists every status core defines (storagestate/status.go), adding LOADING, LAZY_LOADING, SHUTDOWN, UNAVAILABLE, RECOVERING. per_node_status values use it.

CI. Matrix adds 1.40.0 and bumps 1.39 to 1.39.10 and 1.38 to 1.38.20; integration, journey and pyodide jobs run on 1.40.0. Two tests needed changes for current servers: the shards test compared per_node_status keys (1.40 populates the map), and servers from 1.38.19 / 1.39.10 / 1.40.0 reject an empty alias name in a permission, so the role case that relied on "" meaning every alias is dropped (the "*" case covers the same path). The authlib dev pin now satisfies the package requirement. The embedded default moves to 1.40.0 (the integration_embedded suite passes locally and reports 1.40.0).

Tests: new parametrized reader test, a mock get_shards test, and a gated HFresh MUVERA integration test. Full integration/ on 1.40.0: 1147 passed, remaining failures are auth containers not present locally.

The HFresh config reader hardcoded multi_vector=None, so config.get() dropped the MUVERA settings the server returns. Parse the multivector block with the shared helper, as the HNSW and flat readers do. ShardTypes now lists every shard status core defines, including UNAVAILABLE and RECOVERING, and per_node_status values use it.
Add 1.40.0 to the matrix and move the integration, journey and pyodide jobs to it. The shards test read per_node_status keys, which 1.40 populates, so compare its values. Servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias name in a permission, so gate that case. Bump the authlib dev pin to match the package requirement.
@g-despot
g-despot requested a review from a team as a code owner October 8, 2026 12:34

@orca-security-eu orca-security-eu Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.12%. Comparing base (95b5d76) to head (83722d2).
⚠️ Report is 200 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_collection_hfresh.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2190      +/-   ##
==========================================
+ Coverage   86.64%   89.12%   +2.48%     
==========================================
  Files         300      308       +8     
  Lines       23172    24429    +1257     
==========================================
+ Hits        20077    21772    +1695     
+ Misses       3095     2657     -438     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…every alias

Servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias pattern in a permission. The "*" case next to it covers the same client path.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants