Repository navigation
Conversation
The HFresh config reader hardcoded multi_vector=None, so config.get() dropped the MUVERA settings the server returns. Parse the multivector block with the shared helper, as the HNSW and flat readers do. ShardTypes now lists every shard status core defines, including UNAVAILABLE and RECOVERING, and per_node_status values use it.
Add 1.40.0 to the matrix and move the integration, journey and pyodide jobs to it. The shards test read per_node_status keys, which 1.40 populates, so compare its values. Servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias name in a permission, so gate that case. Bump the authlib dev pin to match the package requirement.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
+ Coverage 86.64% 89.12% +2.48%
==========================================
Files 300 308 +8
Lines 23172 24429 +1257
==========================================
+ Hits 20077 21772 +1695
+ Misses 3095 2657 -438 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…every alias Servers from 1.38.19, 1.39.10 and 1.40.0 reject an empty alias pattern in a permission. The "*" case next to it covers the same client path.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix.
config.get()returnedmulti_vector=Nonefor every HFresh index because the HFresh reader hardcoded it. It now parses the server'smultivectorblock with the same helper the HNSW and flat readers use, so MUVERA settings round-trip. Verified live against 1.40.0:_MultiVectorConfig(encoding=_MuveraConfig(enabled=True, ksim=4, dprojections=16, repetitions=10)), and a plain HFresh vector still reads backNone.Typing.
ShardTypeslists every status core defines (storagestate/status.go), addingLOADING,LAZY_LOADING,SHUTDOWN,UNAVAILABLE,RECOVERING.per_node_statusvalues use it.CI. Matrix adds 1.40.0 and bumps 1.39 to 1.39.10 and 1.38 to 1.38.20; integration, journey and pyodide jobs run on 1.40.0. Two tests needed changes for current servers: the shards test compared
per_node_statuskeys (1.40 populates the map), and servers from 1.38.19 / 1.39.10 / 1.40.0 reject an empty alias name in a permission, so the role case that relied on""meaning every alias is dropped (the"*"case covers the same path). Theauthlibdev pin now satisfies the package requirement. The embedded default moves to 1.40.0 (theintegration_embeddedsuite passes locally and reports1.40.0).Tests: new parametrized reader test, a mock
get_shardstest, and a gated HFresh MUVERA integration test. Fullintegration/on 1.40.0: 1147 passed, remaining failures are auth containers not present locally.