fix: ignore* option parity with resemble (pixelmatch)#1181
Open
wswebcreation wants to merge 4 commits into
Open
fix: ignore* option parity with resemble (pixelmatch)#1181wswebcreation wants to merge 4 commits into
wswebcreation wants to merge 4 commits into
Conversation
- apply last-wins threshold and AA rules for ignoreLess, ignoreAlpha, ignoreColors, and ignoreNothing - keep forgiving default when only ignoreAntialiasing applies - add unit and executeImageCompare integration tests - add patch changeset for image-comparison-core and visual-service
- replace BT.601 grayscale preprocessing in compareImages - add unit and integration tests for ignoreColors parity - add patch changeset for image-comparison-core and visual-service
- add PNG fixture pairs for each ignore* scenario from the parity plan - add ignore-options.parity.test.ts with expected pass/fail matrix - document fixtures and regeneration steps in README
- add JSDoc preset mapping on each ignore* option - add README section with comparison table and last-wins semantics - remove redundant ignoreAntialiasing from Sauce/Lambda configs - add patch changeset
🦋 Changeset detectedLatest commit: f7ff230 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration PR for v10 pixelmatch
ignore*parity with resemble.js. Merges four feature branches fromws-ignore-feature-parity:resolveComparePresetignoreColorsuses resemble luma (0.3/0.59/0.11) instead of BT.601 grayscaleignoreAntialiasing: truefrom Sauce/Lambda configsBuilds on #1175 (
ignoreAntialiasingtoggle, defaulttrue).Behaviour highlights
ignore*configignoreAntialiasing: true)ignoreLess+ default antialiasingignoreColorshue-only diffalpha→antialiasing→colors→less→nothing