feat: humanize format - #68
Closed
vankop wants to merge 1 commit into
Closed
Conversation
vankop
commented
Oct 13, 2019
|
|
||
| export default (ajv) => | ||
| export default (ajv) => { | ||
| ajv.addFormat('absolutePath', () => true); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 98.57% 98.47% -0.10%
==========================================
Files 5 6 +1
Lines 561 592 +31
Branches 252 259 +7
==========================================
+ Hits 553 583 +30
- Misses 8 9 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/cc @vankop we can continue a work on the PR |
evenstensberg
left a comment
evenstensberg
left a comment
Member
There was a problem hiding this comment.
could you rebase? I can work on this if it's stale
This was referenced Sep 8, 2026
Member
|
Thank you for this @vankop, and sorry it sat for so long. Splitting it in two:
Closing as superseded by #225. Generated by Claude Code |
alexander-akait
added a commit
that referenced
this pull request
Sep 8, 2026
A `format` was reported as a hint next to the constraints of the string:
configuration.strictFormat should be a string (should match format "date", should be < "2016-02-06").
It names the string, so it now reads as part of the type:
configuration.strictFormat should be a date string (should be < "2016-02-06").
The name is turned into words, so a `date-time`, a `snake_case` and a
`camelCase` format all read as words. A format is any string though, not only
a name - one that is not a name, such as the pattern `[0-9]*`, is still
reported as a hint, and so is a negated format, which no type can state.
Taken from #68, without the part of it moving `absolutePath` from a keyword
to a format, which is breaking and was left open for discussion there.
Claude-Session: https://claude.ai/code/session_013wqLmVHkAGBsWQgXknEQCK
Co-authored-by: Ivan Kopeykin <10380560+vankop@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
#66
Breaking Changes
Yes
Additional Info
I think it is a point to discuss, should schema-utils move
absolutePathto custom format instead of keyword