Add alternate payment credential headers - #821
Merged
brendanjryan merged 1 commit intoAug 25, 2026
Merged
Conversation
commit: |
brendanjryan
marked this pull request as ready for review
August 21, 2026 00:36
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1c70e84b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@brendanjryan incorporated your feedback to get the the |
brendanjryan
approved these changes
Aug 25, 2026
Advertise an optional challenge header so Payment credentials can use Payment-Authorization while Authorization stays available for ordinary auth. Includes the default-Authorization behavior and drops internal plan notes.
raubrey-stripe
force-pushed
the
raubrey/alternative-auth-header-challenge
branch
from
August 25, 2026 00:52
212af53 to
410a9c5
Compare
brendanjryan
approved these changes
Aug 25, 2026
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using MPP in conjunction with traditional Auth schemes that use the
Authorizationheader (like an API Key riding inAuthorization: Bearer sk_...) there are conflicts - namely,Authorizationheader does not support multiple values.I'm proposing a change to the MPP challenge that indicates in the
WWW-Authenticateresponse header what request header the client should put the payment challenge into.Proposed new
headerfield in challengeIf
headeris not included, the challenge should be included in theAuthorizationheader.