Skip to content

fix(tempo): preserve dispatched session vouchers - #827

Open
parvahuja wants to merge 2 commits into
mainfrom
parv/fix-session-response-recovery
Open

fix(tempo): preserve dispatched session vouchers#827
parvahuja wants to merge 2 commits into
mainfrom
parv/fix-session-response-recovery

Conversation

@parvahuja

@parvahuja parvahuja commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Why

A session manager rolled cumulative authorization backward when a paid request threw after dispatch, even though the server could already have accepted that signed voucher. An idempotent retry without a receipt then left close unable to reconcile the server snapshot.

What

  • Capture the exact active or resumed voucher state handed to a non-aborted fetch.
  • Preserve monotonic authorization only for ambiguous post-dispatch failures; keep rollback for pre-dispatch, already-aborted, and known rejection failures.
  • Cover active and resumed channels, receiptless idempotent recovery, and the snapshot-driven HTTP retry path.

@pkg-pr-new

pkg-pr-new Bot commented Aug 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/mppx@827

commit: 17e0ec1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c804a30c4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tempo/session/client/SessionManager.ts
Comment thread src/tempo/session/client/SessionManager.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant