Replace Aruba with direct API calls#571
Conversation
|
@etagwerker, @JuanVqz Would you rather remove the Aruba requirement, or just manage its progression? |
There was a problem hiding this comment.
@faisal Thanks for this.
The justification checks out: with the Cucumber features already gone, aruba is the only dev dependency still pulling in cucumber and rspec-expectations, both of which cap diff-lcs at < 2.0.
Removing aruba is what unblocks diff-lcs ~> 2.0, and I confirmed Diff::LCS.sdiff/unchanged? (the only API we use in test_helper.rb) still works on diff-lcs 2.0 CI is green across all Ruby versions.
To answer your question: let's remove aruba, this PR does it cleanly.
cc @etagwerker
Aruba is a recurring source of dependency conflicts when updating Rubycritic dependencies*. Update Aruba call sites to call the underlying command line calls directly. Call with Open3 so as to capture results and return status. * Most recently, being able to update to diff-lcs 2.0, which we do in this commit. We ran into it more before when Rubycritic relied on Cucumber, though it doesn't any more. Credit to @JuanVqz for the timeout handling code in IntegrationTestHelper.
|
Took @JuanVqz's tweak (thank you!), suppressed the resulting rubocop warning, and squashed down to one commit. |
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@faisal Looks good, thanks!
3 participants
Aruba is a recurring source of dependency conflicts when updating Rubycritic dependencies*. Update Aruba call sites to call the underlying command line calls directly. Call with Open3 so as to capture results and return status.
*Most recently, being able to update to diff-lcs 2.0, which we do in this commit. We ran into it more before when Rubycritic relied on Cucumber, though it doesn't any more.Check list: