Skip to content

refactor: conversation screen [WPB-25864] - #5143

Queued
Garzas wants to merge 8 commits into
developfrom
refactor/conversation-screen
Queued

refactor: conversation screen [WPB-25864]#5143
Garzas wants to merge 8 commits into
developfrom
refactor/conversation-screen

Conversation

@Garzas

@Garzas Garzas commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25864


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Restructures the Conversation Screen in preparation for upcoming keyboard accessibility improvements.

It extracts the message list, message composer, dialogs, and navigation result handling into separate components. ViewModel dependencies are also hoisted so extracted composables receive state and callbacks.

This is a behavior-preserving refactor. Keyboard navigation changes will be introduced in a follow-up PR.

@Garzas Garzas self-assigned this Aug 7, 2026
@pull-request-size

Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 1.40845% with 210 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.43%. Comparing base (8a5c889) to head (88b4c04).

Files with missing lines Patch % Lines
...nversations/messagelist/ConversationMessageList.kt 1.64% 177 Missing and 2 partials ⚠️
...droid/ui/home/conversations/ConversationDialogs.kt 0.00% 27 Missing ⚠️
...ome/conversations/ConversationNavigationResults.kt 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (1.40%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5143      +/-   ##
===========================================
- Coverage    50.85%   50.43%   -0.43%     
===========================================
  Files          670      673       +3     
  Lines        24452    24665     +213     
  Branches      3830     3882      +52     
===========================================
+ Hits         12436    12439       +3     
- Misses       10870    11078     +208     
- Partials      1146     1148       +2     
Files with missing lines Coverage Δ
...ome/conversations/ConversationNavigationResults.kt 0.00% <0.00%> (ø)
...droid/ui/home/conversations/ConversationDialogs.kt 0.00% <0.00%> (ø)
...nversations/messagelist/ConversationMessageList.kt 1.64% <1.64%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5c889...88b4c04. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 227 tests  ±0   2 227 ✅ ±0   2m 5s ⏱️ +13s
  242 suites ±0       0 💤 ±0 
  242 files   ±0       0 ❌ ±0 

Results for commit 88b4c04. ± Comparison against base commit 8a5c889.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
com.wire.android.ui.home.conversations.ConversationScreenTest ‑ givenEligibleState_whenCheckingAutoTrigger_thenReturnsTrue()
com.wire.android.ui.home.conversations.ConversationScreenTest ‑ givenRemoteHistoryExhausted_whenCheckingAutoTrigger_thenReturnsFalse()
com.wire.android.ui.home.conversations.ConversationScreenTest ‑ givenSelectedMessage_whenCheckingAutoTrigger_thenReturnsFalse()
com.wire.android.ui.home.conversations.messagelist.ConversationMessageListTest ‑ givenEligibleState_whenCheckingAutoTrigger_thenReturnsTrue()
com.wire.android.ui.home.conversations.messagelist.ConversationMessageListTest ‑ givenRemoteHistoryExhausted_whenCheckingAutoTrigger_thenReturnsFalse()
com.wire.android.ui.home.conversations.messagelist.ConversationMessageListTest ‑ givenSelectedMessage_whenCheckingAutoTrigger_thenReturnsFalse()

♻️ This comment has been updated with latest results.

@Garzas
Garzas requested review from saleniuk and yamilmedina August 7, 2026 13:32
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Garzas
Garzas added this pull request to the merge queue Aug 10, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants