WPB-27892: fix: resolve original caller for call-end "called" message - #22101
Draft
blackheaven wants to merge 1 commit into
Draft
WPB-27892: fix: resolve original caller for call-end "called" message#22101blackheaven wants to merge 1 commit into
blackheaven wants to merge 1 commit into
Conversation
handleMissedCall injected the deactivate event with the missedh userId (the sender of the missed-trigger message), so the "$USER called" conversation message named the wrong participant. Use the original caller captured at ring time (call.initiator = AVS SETUP sender) when a Call object exists for the conversation, falling back to the missedh userId only when none is present (e.g. the app cold-launched straight into a missed call). callClosed already used call.initiator.
blackheaven
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27892
handleMissedCall injected the deactivate event with the missedh userId (the sender of the missed-trigger message), so the "$USER called" conversation message named the wrong participant.
Use the original caller captured at ring time (call.initiator = AVS SETUP sender) when a Call object exists for the conversation, falling back to the missedh userId only when none is present (e.g. the app cold-launched straight into a missed call). callClosed already used call.initiator.
It's LLM-generated, please, review it carefully.
Depends on wireapp/wire-avs#199