Repository navigation
fix: Present empty folder sizes as zero [WPB-27776] - #22103
Merged
Merged
Conversation
cristianoliveira
marked this pull request as ready for review
August 4, 2026 14:41
Normalize absent Cells node sizes to zero in both global Drive and conversation views so empty folders display a meaningful, comparable size. Cover null and omitted backend values in both transformation paths. Jira: https://wearezeta.atlassian.net/browse/WPB-27776
Replace the separate global and conversation node mappers with one shared Cells transformation. Keep conversation enrichment optional so scoped views can use the same mapping without requiring workspace context. Jira: https://wearezeta.atlassian.net/browse/WPB-27776
Name the transformer test factory as a stub so its testing purpose is explicit at each call site. Jira: https://wearezeta.atlassian.net/browse/WPB-27776
Keep absent file size metadata displayed as unknown while empty folders continue to show zero bytes. Add regression coverage for null and omitted file sizes. Jira: https://wearezeta.atlassian.net/browse/WPB-27776
cristianoliveira
force-pushed
the
feat/WPB-27776-present-null-sizes-as-zero
branch
from
August 5, 2026 12:46
46bb8ea to
9d5f903
Compare
zskhan
previously approved these changes
Aug 6, 2026
Use the shared null-or-undefined predicate when identifying missing Cells node sizes, making the intent explicit and consistent with the codebase. Jira: https://wearezeta.atlassian.net/browse/WPB-27776
zskhan
approved these changes
Aug 7, 2026
Contributor
First appeared in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Empty folders in Cells can have a null or omitted size. This currently produces an unavailable or invalid size instead of a meaningful value users can compare.
Jira: WPB-27776
Approach
Use one shared Cells node transformation for global Drive, conversation browsing, and conversation search. Normalize null and omitted sizes to zero before formatting, while optionally enriching global results with conversation data.