chore (e2e): Implement e2e tests TC-1735 and TC-1756 [WPB-25491] - #22124
Merged
Conversation
thisisamir98
requested changes
Aug 6, 2026
thisisamir98
left a comment
thisisamir98
left a comment
Collaborator
There was a problem hiding this comment.
Summary
Nice addition of Keycloak and SCIM helpers for TC-1735 and TC-1756. The main risk is that TC-1756 can pass without proving the SCIM account fields are locked, because some account page locators do not match the real edit controls.
Findings
Blocking
- TC-1756 display name and username checks use the wrong page object locators, so the test does not lock the SCIM restriction.
Should fix
- SSO page readiness wait is not used after
openSSOPage. afterEachcleanup can call Keycloak delete with undefined ids when setup fails mid-way.- Test title mentions profile color, but the step never asserts it, and accent color is still editable for SCIM users in the app.
Nits
- Unused
BACKEND_URLcheck increateSCIMAccessToken.
Questions
- Is email meant to be locked by SCIM here, or is it already hidden because the user is SSO (
isNoPasswordSSO)?
thisisamir98
previously approved these changes
Aug 6, 2026
screendriver
approved these changes
Aug 7, 2026
Contributor
First appeared in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.