Fenrir fixes#32
Conversation
e3c3ed4 to
074e9cb
Compare
e1c893f to
b89e8ef
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #32
Scan targets checked: go-wolfssl-bugs, go-wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
77b0163 to
a29dc26
Compare
| const BAD_FUNC_ARG = int(C.BAD_FUNC_ARG) | ||
|
|
||
| func ConstantCompare(a, b []byte, length int) int { | ||
| if length < 0 || length > len(a) || length > len(b) { return 0 } |
There was a problem hiding this comment.
This check should stay because it's not passed to wc
ad240b6 to
88ea47b
Compare
88ea47b to
6f647a2
Compare
|
After looking over it again and testing, I restored the Go-boundary length checks wc can't see (slice-len vs passed-size, digest-output size, pre-cgo slicing) and left the semantic ones (key/IV/block-alignment) delegated to wc (wolfssljni follows this same approach). Without these we'd get real crashes / silent overflows, and the earlier bugs I hit were all semantic — which is the riskier category anyway. |
1df93cd to
60e046b
Compare
60e046b to
73e818c
Compare
Fixes F-1414, F-1415, F-1416, F-1417, F-1418, F-1419, F-1410, F-1411, F-1420, F-1421, F-1422, F-1412, F-1413, F-1780