Remove wolfCrypt patches#3
Merged
Merged
Conversation
The fixes are now in wolfCrypt, so the patches in Dockerfiles need to be removed.
There was a problem hiding this comment.
Pull request overview
This PR removes local wolfCrypt/wolfSSL patching from simulator Docker build flows and updates documentation accordingly, based on the assumption that the required fixes are now available upstream in wolfCrypt/wolfSSL.
Changes:
- STSAFEA120Sim: switch wolfSSL ref to
master, remove patching steps, and enable STSAFE-A120 via configure flag. - ATECC608Sim: remove wolfSSL source patching and stop pinning to
v5.9.1-stable; update README to reflect the new upstream dependency. - SE050Sim: update README project tree to drop the removed
patches/directory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| STSAFEA120Sim/Dockerfile.wolfcrypt | Removes in-Docker wolfSSL patching and changes wolfSSL ref to master; enables STSAFE-A120 in configure. |
| SE050Sim/README.md | Updates tree listing to remove patches/ entries. |
| ATECC608Sim/README.md | Updates wolfSSL version notes and removes now-obsolete patch description. |
| ATECC608Sim/Dockerfile.wolfcrypt | Removes wolfSSL patching steps and switches to cloning upstream wolfSSL without a pinned ref. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixes are now in wolfCrypt, so the patches in Dockerfiles need to be removed.