Add STM32U5 and H7 simulators with hardware crypto#5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 62 out of 62 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
STM32Sim/stm32-sim/peripherals/Cargo.toml:30
- The dev-dependency on
aes-gcmpins a version directly instead of using the workspace dependency, which can lead to duplicate/discordant versions across the workspace. Preferaes-gcm.workspace = truehere to keep dependency versions consistent.
Add a Unicorn-Engine-based STM32 simulator for wolfSSL CI. The new STM32Sim/ tree is a Rust workspace splitting CPU + MMIO bus + ELF loader (core/), per-revision peripheral models (peripherals/), and chip wiring (chips/); two chip targets, STM32H753 (HAL v1) and STM32U575 (HAL v2), share one set of cryptographic engines (AES ECB/CBC/CTR/GCM, SHA-1/224/256/384/512 + MD5, P-256/P-384 ECC mul + RSA modexp) through revision-specific register adapters, so adding further STM32 families is a new chip file plus an adapter, not engine work. The repo includes Cortex-M7 and Cortex-M33 smoke firmwares that exercise the full peripheral stack, GitHub Actions workflows, and 29 unit tests + 2 firmware integration tests covering NIST/FIPS KATs and a cross-check against the RustCrypto aes-gcm crate (which incidentally surfaces a typo in the canonical McGrew GCM Test Case 2 tag, documented in the test).
dgarske
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Unicorn-Engine-based STM32 simulator for wolfSSL CI. The new STM32Sim/ tree is a Rust workspace splitting CPU + MMIO bus + ELF loader (core/), per-revision peripheral models (peripherals/), and chip wiring (chips/); two chip targets, STM32H753 (HAL v1) and STM32U575 (HAL v2), share one set of cryptographic engines (AES ECB/CBC/CTR/GCM, SHA-1/224/256/384/512 + MD5, P-256/P-384 ECC mul + RSA modexp) through revision-specific register adapters, so adding further STM32 families is a new chip file plus an adapter, not engine work. The repo includes Cortex-M7 and Cortex-M33 smoke firmwares that exercise the full peripheral stack, GitHub Actions workflows, and 29 unit tests + 2 firmware integration tests covering NIST/FIPS KATs and a cross-check against the RustCrypto aes-gcm crate (which incidentally surfaces a typo in the canonical McGrew GCM Test Case 2 tag, documented in the test).