Set keyAllocated=1 when initializing any key - #1038
Merged
Merged
Conversation
padelsbach
marked this pull request as ready for review
June 16, 2026 06:22
ejohnstown
requested changes
Jun 18, 2026
ejohnstown
requested changes
Jun 18, 2026
ejohnstown
requested changes
Jun 18, 2026
padelsbach
force-pushed
the
keyallocated-flag
branch
from
June 18, 2026 23:10
00125b0 to
4301898
Compare
ejohnstown
self-requested a review
June 19, 2026 00:09
ejohnstown
reviewed
Jun 19, 2026
padelsbach
force-pushed
the
keyallocated-flag
branch
from
June 19, 2026 01:59
4301898 to
d5e96c1
Compare
padelsbach
force-pushed
the
keyallocated-flag
branch
from
June 19, 2026 02:30
d5e96c1 to
dae7454
Compare
ejohnstown
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a possible memory leak if parsing fails. Only a problem with
--enable-heapmathsince normal spmath does not allocate buffers for the key.Added unit tests and heapmath variant to CI.
Also, adding heapmath+asan uncovered a second unrelated leak when freeing the KEX key. Fix included as a second commit.