Drop redundant mlkem.h include#960
Merged
padelsbach merged 1 commit intowolfSSL:masterfrom Apr 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Autoconf detection flow and compilation guards to safely include ML-KEM headers only when they are available, aligning configure.ac checks with the resolved wolfSSL include path and preventing build failures when wolfssl/wolfcrypt/mlkem.h is missing.
Changes:
- Moves
AC_CHECK_HEADERS/AC_CHECK_LIBto run after the wolfSSL--with-wolfsslpath handling so the computedCPPFLAGS/LDFLAGSare applied. - Adds
wolfssl/wolfcrypt/mlkem.hto the Autoconf header probes (generatingHAVE_WOLFSSL_WOLFCRYPT_MLKEM_H). - Guards the
mlkem.hinclude insrc/internal.cbehindHAVE_WOLFSSL_WOLFCRYPT_MLKEM_H.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/internal.c |
Adds an Autoconf-driven compile guard around the optional mlkem.h include. |
configure.ac |
Reorders and expands header/library checks so wolfSSL path flags are applied and mlkem.h is probed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
padelsbach
reviewed
Apr 30, 2026
Contributor
padelsbach
left a comment
padelsbach
left a comment
There was a problem hiding this comment.
Guessing the goal of this PR is to support an older wolfssl without mlkem -- is that right? Is there a specific version that I can try?
padelsbach
approved these changes
Apr 30, 2026
ejohnstown
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop redundant mlkem.h include. wc_mlkem.h used to include it already. mlkem.h was merged with wc_mlkem.h as of today.