ci: add wycheproof vector test job#10258
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a dedicated GitHub Actions workflow to run wolfSSL against the wolfSSL/wychcheck (Wycheproof + vector) suite on pushes and PRs, and to publish JUnit XML results as an artifact.
Changes:
- Introduces
.github/workflows/wycheproof.ymlwith a newwycheproofCI job. - Builds wolfSSL from the PR branch, builds
wolfcrypt-checkfromwolfSSL/wychcheck, and executesctestwith JUnit output. - Uploads the generated JUnit XML as a workflow artifact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cd090b5 to
2d7c9a4
Compare
2d7c9a4 to
ff2fe91
Compare
|
All review feedback addressed in the current commit (ff2fe91):
The May 1st CI failure was caused by the invalid |
Add GitHub Actions workflow that builds wolfSSL, checks out wolfSSL/wychcheck, and runs Wycheproof test vectors via ctest. Uploads JUnit XML results as artifact.
wychcheck's CMakeLists.txt reads WOLFSSL_DIR from the environment
($ENV{WOLFSSL_DIR}), which overwrites any -D cache variable. Pass it
as an env var so cmake picks it up correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ff2fe91 to
fcb1619
Compare
|
Root cause: wychcheck's CMakeLists.txt reads |
Summary
.github/workflows/wycheproof.ymlwhich builds wolfSSL from the PR branch and runs it against the wolfSSL/wychcheck test suite (340+ Wycheproof JSON test files, NIST ACVP vectors, and RFC vectors covering AES-GCM, AES-EAX, AES-SIV, ChaCha20-Poly1305, RSA-PSS, RSA-OAEP, ECDH/ECDSA over all curves, X25519, ML-DSA, ML-KEM, SLH-DSA, EdDSA)if: github.repository_owner == 'wolfssl'per project conventionwycheproofsubmodule (notacvp-serverwhich is 900 MB)Relationship to wychcheck
wolfSSL/wychcheckalready runs nightly againstwolfssl/wolfsslmaster (Saturday 22:00 UTC). This job adds per-PR coverage so regressions are caught before merge rather than after.Test plan
wolfcrypt-checkbuilds and ctest passeswycheproof-results/test-results.xml