Add STSAFE A120 CI support#10375
Open
LinuxJedi wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
Adds our STSAFE A120 simulator to the CI, adds STSAFE to configure.ac and fix missing required header.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds autotools and CI wiring to build/test wolfCrypt against the STSAFE-A120 simulator, and aligns the STSAFE port source inclusion with an explicit ./configure option.
Changes:
- Fix STSAFE-A120 build by including
stse_platform_generic.hbeforestselib.h. - Add
./configure --enable-stsafe[=a100|a120]and aBUILD_STSAFEautomake conditional to compilestsafe.conly when enabled. - Add a new GitHub Actions workflow to build and run the STSAFE-A120 simulator-based test in CI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
wolfcrypt/src/port/st/stsafe.c |
Adds required STSELib platform header include for A120 builds. |
wolfcrypt/src/include.am |
Moves stsafe.c into conditional library sources guarded by BUILD_STSAFE. |
configure.ac |
Introduces --enable-stsafe flag (a100/a120) and corresponding automake conditional + config summary output. |
.github/workflows/stsafe-a120-sim.yml |
New CI job to build the simulator container with PR sources and run STSAFE-A120 tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Jenkins retest this please, Windows failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds our STSAFE A120 simulator to the CI, adds STSAFE to configure.ac and fix missing required header.