Regression testing fixes - memory allocation failure testing#10652
Open
SparkiDev wants to merge 1 commit into
Open
Regression testing fixes - memory allocation failure testing#10652SparkiDev wants to merge 1 commit into
SparkiDev wants to merge 1 commit into
Conversation
Contributor
Author
|
Jenkins: retest this please |
crl.c, internal.h: leak of sigParams requiring reorder the struct fields to that it is above memcpy part. dtl13.c: free the DRLS fragments buffer in Dtls13FreeFsmResources in case fragment is never sent. ocsp.c: only free cid if locally allocated. tls.c: make sure ecc_kse is zeroized and can be freed. tls13.c: set hsHashesEch after init so isn't lost on failure. evp_pk.c: free key on the BIO error path Fixed various tests to not leak or crash on memory allocation failure.
16bc473 to
6289c62
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
crl.c, internal.h: leak of sigParams requiring reorder the struct fields to that it is above memcpy part.
dtl13.c: free the DRLS fragments buffer in Dtls13FreeFsmResources in case fragment is never sent.
ocsp.c: only free cid if locally allocated.
tls.c: make sure ecc_kse is zeroized and can be freed.
tls13.c: set hsHashesEch after init so isn't lost on failure.
evp_pk.c: free key on the BIO error path
Fixed various tests to not leak or crash on memory allocation failure.
Testing
Memory allocation failure testing.