Skip to content

Support path-level parameters in code generation#282

Merged
miniBill merged 2 commits intowolfadex:mainfrom
zupo:fix/path-level-params
Apr 20, 2026
Merged

Support path-level parameters in code generation#282
miniBill merged 2 commits intowolfadex:mainfrom
zupo:fix/path-level-params

Conversation

@zupo
Copy link
Copy Markdown
Contributor

@zupo zupo commented Mar 6, 2026

Merge path item parameters with operation parameters per the OpenAPI spec. Previously, parameters defined at the path level (shared across all operations) were silently ignored, causing path params to appear as literal strings in generated URLs.

@zupo zupo force-pushed the fix/path-level-params branch from 5d7c6bc to 3d634c3 Compare March 6, 2026 23:28
Comment thread cli/src/TestGenScript.elm Outdated
Comment thread src/OpenApi/Generate.elm Outdated
Comment thread src/OpenApi/Generate.elm Outdated
@zupo zupo force-pushed the fix/path-level-params branch 3 times, most recently from 6f04ac5 to 5196394 Compare March 8, 2026 11:08
Comment thread cli/src/TestGenScript.elm Outdated
@zupo zupo requested a review from miniBill March 8, 2026 11:10
Comment thread cli/src/TestGenScript.elm Outdated
Comment thread src/OpenApi/Generate.elm
Comment thread src/OpenApi/Generate.elm
@zupo
Copy link
Copy Markdown
Contributor Author

zupo commented Mar 8, 2026

Thanks for all the improvements, definitely above my elm pay grade.

@miniBill
Copy link
Copy Markdown
Collaborator

miniBill commented Apr 1, 2026

I'd say this is now almost ready to merge, could you resolve the conflicts?

@zupo zupo force-pushed the fix/path-level-params branch 3 times, most recently from dc4824e to cb4d270 Compare April 15, 2026 18:39
@zupo zupo requested a review from miniBill April 15, 2026 18:40
@zupo zupo force-pushed the fix/path-level-params branch from cb4d270 to acc2494 Compare April 16, 2026 16:44
@zupo
Copy link
Copy Markdown
Contributor Author

zupo commented Apr 17, 2026

Anything else I can do to help this one get merged?

@miniBill

This comment was marked as outdated.

Merge path item parameters with operation parameters per the OpenAPI
spec. Previously, parameters defined at the path level (shared across
all operations) were silently ignored, causing path params like {orgId}
to appear as literal strings in generated URLs.
@miniBill miniBill force-pushed the fix/path-level-params branch from acc2494 to a27f89f Compare April 20, 2026 15:57
@miniBill miniBill merged commit 3af46b5 into wolfadex:main Apr 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants