Refactor Logged class __new__ method return type annotation#45
Open
RamogninoF wants to merge 2 commits intowolph:developfrom
Open
Refactor Logged class __new__ method return type annotation#45RamogninoF wants to merge 2 commits intowolph:developfrom
RamogninoF wants to merge 2 commits intowolph:developfrom
Conversation
…_ method in Logged class
There was a problem hiding this comment.
Code Review
This pull request removes the explicit return type hint from the new method in python_utils/logger.py. The feedback suggests using types.Self as a return type instead of removing the annotation entirely, which ensures better type safety for subclasses and maintains consistent type hinting across the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the
__new__method signature inpython_utils/logger.py, removing the unnecessary explicit return type annotation.The explicit type-hint over-constrained the return to Logged instances also for derived classes. Therefore, instantiation of derived class tricked the type-checker to thinking it was instantiating a Logged instance, instead of the an instance of the derived class.