Floor the display scale when sizing remote images#25697
Open
crazytonyli wants to merge 1 commit into
Open
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32815 | |
| Version | PR #25697 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0b7aa3b | |
| Installation URL | 0es8pk48f0h98 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32815 | |
| Version | PR #25697 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0b7aa3b | |
| Installation URL | 3skp7kn3msbsg |
Replace UIScreen.main.scale with max(1, traitCollection.displayScale) in the post and page list cells, the networking image download, and the theme screenshot URL. The view's traitCollection.displayScale can be 0 before its traits resolve, so flooring at 1 (matching AsyncImageKit's ImageSize) avoids zero-size image requests.
crazytonyli
force-pushed
the
task/displayscale-image-size-floor
branch
from
04b24b2 to
0b7aa3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace UIScreen.main.scale with max(1, traitCollection.displayScale). The view's traitCollection.displayScale can be 0 before its traits resolve, so flooring at 1 (matching AsyncImageKit's ImageSize) avoids zero-size image requests.