Skip to content

Add search to Comments v2 - #26024

Open
crazytonyli wants to merge 2 commits into
trunkfrom
task/comments-v2-search
Open

crazytonyli wants to merge 2 commits into
trunkfrom
task/comments-v2-search

Conversation

@crazytonyli

@crazytonyli crazytonyli commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@dangermattic

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@crazytonyli crazytonyli changed the title task/comments v2 search Add search to Comments v2 Sep 16, 2026
@wpmobilebot

wpmobilebot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number35021
VersionPR #26024
Bundle IDorg.wordpress.alpha
Commit06802e2
Installation URL5qqf0gsdvjp60
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number35021
VersionPR #26024
Bundle IDcom.jetpack.alpha
Commit06802e2
Installation URL44pbsvnekpg6g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from b2f971c to 77d632b Compare September 22, 2026 07:29
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from 77d632b to da9d95f Compare October 12, 2026 08:53
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from da9d95f to 2c7b453 Compare October 13, 2026 21:09
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from 2c7b453 to 06802e2 Compare October 16, 2026 00:37
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from 06802e2 to e400d34 Compare October 29, 2026 20:38
Base automatically changed from task/comments-v2-review-pending to trunk November 5, 2026 23:07
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch 2 times, most recently from 20ed2d1 to 9a70a8c Compare November 8, 2026 19:20
@crazytonyli
crazytonyli marked this pull request as ready for review November 8, 2026 19:22
@crazytonyli
crazytonyli marked this pull request as draft November 9, 2026 21:25
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from 9a70a8c to f9f7edb Compare November 11, 2026 02:36
@crazytonyli
crazytonyli removed this pull request from stack #25981 November 11, 2026 02:39
@crazytonyli
crazytonyli changed the base branch from trunk to task/comment-detail-context November 11, 2026 02:40
@crazytonyli
crazytonyli added this pull request to stack #26028 November 11, 2026 02:44
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from f9f7edb to 6700ad2 Compare November 11, 2026 03:33
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from 6700ad2 to c7c3dd6 Compare November 11, 2026 04:24
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from c7c3dd6 to 76e6df9 Compare November 11, 2026 04:31
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch 2 times, most recently from cc36976 to cdd047d Compare November 16, 2026 02:58
Base automatically changed from task/comment-detail-context to trunk November 16, 2026 03:22
Add CommentsSearchViewModel with query debouncing, result
reconciliation, and pagination, backed by a new searchComments method
on CommentsServiceProtocol. Add unit tests and test fakes.
Wire the search view model into the Comments screen using the native
searchable modifier, presenting matches in a dedicated results view.
@crazytonyli
crazytonyli force-pushed the task/comments-v2-search branch from cdd047d to 9933e35 Compare November 16, 2026 05:40
@crazytonyli
crazytonyli requested a review from jkmassel November 16, 2026 06:17
@crazytonyli crazytonyli added this to the 27.5 milestone Nov 16, 2026
@crazytonyli
crazytonyli marked this pull request as ready for review November 16, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants