Skip to content

AUTH-6734: make skill/MCP install explicit opt-in - #218

Open
nicknisi wants to merge 2 commits into
mainfrom
bosun/task-msh07jgf-fuv6
Open

AUTH-6734: make skill/MCP install explicit opt-in#218
nicknisi wants to merge 2 commits into
mainfrom
bosun/task-msh07jgf-fuv6

Conversation

@nicknisi

@nicknisi nicknisi commented Aug 6, 2026

Copy link
Copy Markdown
Member

bosun task: AUTH-6734: make skill/MCP install explicit opt-in

Task id: task-msh07jgf-fuv6
Shape: ship
Project: workos/cli

AUTH-6734: never install skills/MCP into the user environment without
explicit opt-in. The post-login/post-install setup offer already gates
behind a prompt, but it defaulted to Yes, so an absent-minded Enter
installed skills and MCP config into ~/.claude, ~/.cursor, etc.

- Flip the "Set up now?" confirm to initialValue: false so the default
  answer installs nothing; the only ways anything lands are an explicit
  "yes" at the prompt or an explicit flag (workos setup --yes,
  workos skills install, workos mcp install).
- On decline, print the exact manual-install commands (scoped to what
  was offered) instead of a one-line hint, so opting in later is
  self-serve.
- Document the opt-in policy in the README.

BREAKING CHANGE: the automatic setup offer after login/install now
defaults to No; pressing Enter at the prompt declines instead of
installing. Non-interactive contexts remain untouched (nothing is ever
installed without --yes).
@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

AUTH-6734

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment thread README.md Outdated
Comment on lines +95 to +105
mcp Manage the WorkOS MCP server in coding agents
setup Set up WorkOS skills and the MCP server

`workos setup` installs WorkOS skills and configures the MCP server only after consent. Use `workos skills list` to check skill status, `workos mcp status` to check whether the server definition is configured, or `workos doctor --fix` to refresh stale skills.
**Nothing is installed into your coding agents without explicit opt-in.** The CLI never silently writes skills or MCP configuration into `~/.claude`, `~/.cursor`, etc. After `workos login` or `workos install`, an interactive session may offer to set up your agents — the prompt defaults to **No**, and declining (or running non-interactively) installs nothing. To opt in at any time:

```bash
workos setup # interactive setup (skills + MCP server)
workos setup --yes # non-interactive opt-in
workos skills install # skills only
workos mcp install # MCP server only
````

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 README code fences were converted to 4-backtick fences, breaking the rendered docs

The CLI Options block now opens with a 4-backtick fence (README.md:86) and closes at README.md:105, so everything after it (the "Resource Management:", "Migrations:", "Workflows:" command lists) renders as plain prose instead of a code block — which is also why the leading indentation of those lines had to be stripped in the diff. A stray 4-backtick fence at README.md:144 then opens a new block that swallows the Unclaimed Environments example (its inner ```bash fence at README.md:152 will render literally) until the closing 4-backtick at README.md:162. Recommend reverting these fences to 3-backtick blocks and restoring the indented command list.

(Refers to lines 86-105)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread README.md
workos mcp install # MCP server only
````

Use `workos skills list` to check skill status, `workos mcp status` to check whether the server definition is configured, or `workos doctor --fix` to refresh stale skills you previously installed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 doctor --fix still installs skills into agents that never opted in

The new README text says workos doctor --fix merely refreshes "stale skills you previously installed", but maybeRefreshSkills in src/doctor/index.ts:50-56 triggers a refresh when any detected agent is stale OR has installedVersion === null (i.e. an agent directory exists but WorkOS skills were never installed), and refreshWorkOSSkills then writes skills to every detected agent. Under the PR's "nothing is installed without explicit opt-in" policy this path can still write into ~/.claude/~/.cursor for an agent the user never opted in for. Worth confirming whether --fix should be limited to agents with an existing marker.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes coding-agent skill and MCP installation an explicit opt-in by defaulting the setup prompt to No and providing manual installation instructions after a decline.

  • Changes the setup confirmation default from Yes to No.
  • Adds decline guidance scoped to skills, MCP, or both.
  • Documents the opt-in behavior and fixes the README fence structure.
  • Adds tests for the default response and manual-install guidance.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
README.md Documents explicit opt-in behavior and correctly repairs the Markdown fence boundaries reported in the previous review.
src/commands/setup.ts Defaults automatic setup consent to No and prints appropriately scoped manual installation instructions after a decline.
src/commands/setup.spec.ts Adds coverage for the opt-in default and decline instructions, including skills-only scoping.

Reviews (2): Last reviewed commit: "fix: repair README markdown fence render..." | Re-trigger Greptile

Comment thread README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant