chore(deps): bump oagen to 0.29.0 and oagen-emitters to 0.24.0 - #96
chore(deps): bump oagen to 0.29.0 and oagen-emitters to 0.24.0#96stanleyphu wants to merge 1 commit into
Conversation
Picks up optionalFields support in mutually-exclusive body groups (workos/oagen#147) and the Python emitter fixes for optional variant members and grouped-param import collection (workos/oagen-emitters#209). Unblocks the spec sync in #95: its python sdk_build failure (F821 undefined CreateUserPasswordSaltPosition) and the spurious breaking change from password_salt_position being treated as a required variant member both come from generating with the old versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThe PR upgrades the Oagen parser and emitters to versions that support optional fields in mutually exclusive body groups and fix Python generation issues.
Confidence Score: 4/5The PR appears safe to merge, though the two proxy-specific lockfile URLs should be regenerated against the standard npm registry to keep installation portable. The dependency versions and deduplicated tree are internally consistent, and the only accepted concern is the lockfile's new reliance on a nonstandard tarball host. Files Needing Attention: package-lock.json Important Files Changed
Prompt To Fix All With AI### Issue 1
package-lock.json:1305
**Avoid proxy-specific tarball URLs**
The upgraded packages are now locked to `socket-firewall.workos.dev`, making reproducible installs dependent on a nonstandard host that the repository does not configure. Regenerate these lock entries against the standard npm registry so contributors and CI environments are not unnecessarily coupled to the proxy.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "chore(deps): bump oagen to 0.29.0 and oa..." | Re-trigger Greptile |
| "resolved": "https://registry.npmjs.org/@workos/oagen/-/oagen-0.28.1.tgz", | ||
| "integrity": "sha512-Xfo8y/xQ4AFypemRdRUpHs0byHeYfvLCB1OZ5XKKJfQUVuipgourm50e8G2n/W59LXCBUebWsQ0ihoziIGsDQQ==", | ||
| "version": "0.29.0", | ||
| "resolved": "https://socket-firewall.workos.dev/@workos/oagen/-/oagen-0.29.0.tgz", |
There was a problem hiding this comment.
Avoid proxy-specific tarball URLs
The upgraded packages are now locked to socket-firewall.workos.dev, making reproducible installs dependent on a nonstandard host that the repository does not configure. Regenerate these lock entries against the standard npm registry so contributors and CI environments are not unnecessarily coupled to the proxy.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package-lock.json
Line: 1305
Comment:
**Avoid proxy-specific tarball URLs**
The upgraded packages are now locked to `socket-firewall.workos.dev`, making reproducible installs dependent on a nonstandard host that the repository does not configure. Regenerate these lock entries against the standard npm registry so contributors and CI environments are not unnecessarily coupled to the proxy.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.|
I sorted this out #95 |
Summary
Picks up
optionalFieldssupport in mutually-exclusive body groups (workos/oagen#147, released in v0.29.0) and the Python emitter fixes for optional variant members + grouped-param import collection (workos/oagen-emitters#209, released in v0.24.0).Why now
This unblocks the spec sync in #95. Two of its failures come directly from generating with the old versions:
sdk_build (python):F821 Undefined name 'CreateUserPasswordSaltPosition'— the grouped-param import-collection bug fixed in emitters v0.24.0sdk-compat:password_salt_positionreported as a breaking required addition toPasswordHashed— with v0.29.0 the parser readsoptionalFieldsand the field generates as optional (| None = None), which is non-breakingVerified by generating Python locally with these exact released versions against #95's spec: the import is present and the field is optional. (Remaining breaking changes in #95's report, if any, are from other spec changes in the sync window, not this.)
🤖 Generated with Claude Code