Skip to content

fix: publish release-plz releases after updating notes - #289

Merged
robjtede merged 1 commit into
mainfrom
chore/undraft-releases
Oct 8, 2026
Merged

robjtede merged 1 commit into
mainfrom
chore/undraft-releases

Conversation

@robjtede

@robjtede robjtede commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Create release-plz releases as drafts.
  • Update release notes from the changelog, then publish the releases with --then-undraft.
  • Update the x52dev/nix flake lock input so CI has the new flag.

Validation

  • Reviewed the workflow, release-plz config, and flake.lock diff.
  • Did not run project tests; these changes only affect release configuration.

Summary by CodeRabbit

  • Release Management
    • Newly created releases are now automatically moved out of draft status after their release notes are updated. This makes publication part of the automated release process, so the release is no longer left in draft after the workflow completes. The change applies when the workflow creates releases and uses the existing release notes update step.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5f172d58-faa7-437b-9246-7f501d48ebbe
📥 Commits

Reviewing files that changed from the base of the PR and between 086502e and 48b972d.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

When releases_created is true, the release workflow runs x52-update-release-notes with the --then-undraft option.

Changes

Release workflow

Layer / File(s) Summary
Release-notes command option
.github/workflows/release.yml
The release-notes command now includes --then-undraft.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 48b97

The release-notes command supports the new option and publishes after updating notes. No merge-blocking issue is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: publishing release-plz releases after updating their notes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-08 23:56 UTC

@robjtede
robjtede added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 827819d Oct 8, 2026
10 checks passed
@robjtede
robjtede deleted the chore/undraft-releases branch October 8, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant