Conversation
Contributor
|
I thought MSYS2 has preliminary arm64 support: I would prefer clang64 and clangarm64 if possible. MSVC is going to introduce new headaches. |
Author
Contributor
|
Did you want to reopen it? |
Author
|
Whatever your preference is -- I already opened a new one in #861 -- we can continue the review there if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says. A couple of points to note:
zfp.lib. So I have skipped installing that for tests on Windows ARM64.Let me know if you would like me to change anything on these points.
The CI passes on my fork, although it looks like a disaster because all of the codecov steps and the jobs that need large macos runners fail.