Repository navigation
Conversation
Add an opt-in auto_retry_rate_limits parameter (defaulting to False) to Client.__init__ so callers can automatically sleep for the duration specified in the Retry-After response header and retry when the server returns HTTP 429 (RATE_LIMIT_HIT). Fixes: zulip#773 Co-authored-by: Soham Panda <cozyat@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #773
Completes #908 and addresses @alexmv's review feedback:
auto_retry_rate_limits: bool = FalseonClient.__init__so existing callers that handleRATE_LIMIT_HITresponses themselves are not blocked bytime.sleep().retriesunincremented on429responses since rate limits are expected backpressure with a server-providedRetry-Afterdelay rather than transient network/502 failures, though we can cap consecutive429retries if preferred.How did you test this PR?
zulip/tests/test_rate_limit.pycovering defaultauto_retry_rate_limits=Falsebehavior,Retry-Aftersleep + retry with verbose output, and fallback to1.0s whenRetry-Afteris missing or malformed../tools/test-zulip,mypy,ruff, and./tools/lintSelf-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: