Skip to content

ci: Resurrect dead CI jobs (bullseye Zulip server job; Python 3.9 on ubuntu-latest). - #949

Open
harshvardhan178251 wants to merge 6 commits into
zulip:mainfrom
harshvardhan178251:ci-bullseye-eol
Open

harshvardhan178251 wants to merge 6 commits into
zulip:mainfrom
harshvardhan178251:ci-bullseye-eol

Conversation

@harshvardhan178251

@harshvardhan178251 harshvardhan178251 commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes: n/a (CI-only change; unblocks all future PRs that would otherwise have unfixable red checks)

Problem

Three jobs were dead on every new PR in this repository, before any code is built or tested. All three are upstream infrastructure rot, not regressions in the API client:

  1. Debian 11 (Python 3.9, backend) (Zulip server CI) — the Install dependencies step failed with dozens of 404 Not Found errors from deb.debian.org (bullseye pool pruned; bullseye-security 404 as well). bullseye-pgdg no longer exists on apt.postgresql.org either, so the legacy Zulip 4.0 provisioning couldn't work as-is.
  2. static-analysis and test (ubuntu-latest, 3.9) — GitHub's ubuntu-latest runner (Ubuntu 26.04) no longer provides Python 3.9 via setup-python@v6 (The version '3.9' ... was not found for Ubuntu 26.04.).
  3. test (..., 3.13) — requirements.txt pinned #egg=zulint==1.0.0, a fragment current pip rejects (error: invalid-egg-fragment).

Fix (this PR)

  • zulip-ci.yml — keep the bullseye leg and resurrect it by pointing apt at the archive mirrors. Debian's archive (archive.debian.org/debian, archive.debian.org/debian-security) still carries bullseye/bullseye-updates/bullseye-security, and PGDG's archive (apt-archive.postgresql.org) still carries bullseye-pgdg. The step only applies on the bullseye leg and:
    1. rewrites /etc/apt/sources.list to the archive mirrors,
    2. rewrites the PGDG host in the server's setup-apt-repo to apt-archive.postgresql.org,
    3. drops semgrep==0.50.1 from the server's requirements/dev.txt (removed from PyPI; lint-only, not needed for the API tests — with --require-hashes, the block is deleted cleanly, verified locally).
  • zulip-tests.yml — use 3.10 for static-analysis, and move the test matrix to ["3.10", "3.11", "3.12", "3.13"].
  • requirements.txt — drop the invalid #egg=zulint==1.0.0 fragment; the commit-hash pin is sufficient.

Result on this PR: the bullseye job itself passes (3m29s), running the legacy Zulip 4.0 API compatibility tests end to end. The legacy client-interface-4 signal is preserved rather than dropped.

Alternative the maintainers may prefer instead: removing the bullseye leg entirely (or replacing it with the oldest supported server release). None of those options are possible without resurrecting the job or removing it.

How did you test this PR?

Both workflow YAMLs parse with yaml.safe_load. This PR demonstrates its own fixed checks — see below. The sed range used to delete the semgrep block was verified against the actual requirements/dev.txt from zulip/zulip@4.0, deleting exactly the 5 lines of the requirement.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability.
  • Explains differences from previous plans (resurrection instead of removing the leg).
  • Highlights technical choices and trade-offs.
  • Calls out remaining decisions and concerns (whether patching the checked-out 4.0 server scripts inside CI is acceptable, or maintainers prefer removing the leg instead).
  • Automated tests verify logic where appropriate (n/a; workflows validated).

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Bullseye is EOL: its packages were removed from deb.debian.org (apt 404) and bullseye-pgdg is likewise gone from apt.postgresql.org, so this job fails in the dependency-install step before any code is built or tested. Every recent PR in this repository has failed this job regardless of content. Re-add it (or a replacement based on the oldest supported Zulip server release) once the ci:bullseye image can be rebuilt against archive.debian.org and a PGDG replacement, or a suitable oldest-supported-server job exists.
@harshvardhan178251 harshvardhan178251 changed the title ci: Don't require the bullseye (Debian 11) Zulip server CI job. ci: Remove the bullseye (Debian 11) Zulip server CI job. Nov 14, 2026
GitHub's ubuntu-latest runner (Ubuntu 26.04) no longer provides Python 3.9 through setup-python@v6, so the static-analysis job fails at the setup step and the 3.9 matrix leg fails before any code is built or tested. Windows remains covered for 3.9-era compatibility via existing runners; Ubuntu coverage now starts at 3.10 and adds 3.13.
@harshvardhan178251 harshvardhan178251 changed the title ci: Remove the bullseye (Debian 11) Zulip server CI job. ci: Fix dead CI jobs (bullseye Zulip server job; Python 3.9 on ubuntu-latest). Nov 14, 2026
Current pip rejects the '#egg=zulint==1.0.0' fragment (requires a plain requirement name without a version specifier after it), so provisioning fails in newer build environments, including the 3.13 job. The zulint package is pinned by commit hash, which is sufficient.
Bullseye is EOL and deb.debian.org pruned its pool, so the job failed in setup before any test ran; bullseye-pgdg likewise no longer exists on apt.postgresql.org. Debian's archive (archive.debian.org) still carries bullseye, bullseye-updates, and bullseye-security, and the PGDG archive (apt-archive.postgresql.org) still carries bullseye-pgdg. Point apt and the server provision script at those archives so the legacy Zulip 4.0 client-interface leg can run again instead of dropping it.
The bullseye container runs its build steps as a non-root user, so sed on /etc/apt/sources.list failed with Permission denied; sudo exists in the image (the server provision uses it too).
…llseye job.

semgrep 0.50.1 was removed from PyPI, so provisioning the legacy Zulip 4.0 server fails at the dev requirements install step before any test runs. semgrep is a lint-only tool and is not needed for the documentation/API compatibility tests.
@zulipbot zulipbot added size: M and removed size: S labels Nov 14, 2026
@harshvardhan178251 harshvardhan178251 changed the title ci: Fix dead CI jobs (bullseye Zulip server job; Python 3.9 on ubuntu-latest). ci: Resurrect dead CI jobs (bullseye Zulip server job; Python 3.9 on ubuntu-latest). Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants