added remove method for selectionMenu, add method now return an item - #2761
Open
vikramgaming wants to merge 2 commits into
Open
added remove method for selectionMenu, add method now return an item#2761vikramgaming wants to merge 2 commits into
vikramgaming wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryThe PR extends the selection-menu API while correcting the initialization failure identified in the previous review.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Update src/lib/selectionMenu.js" | Re-trigger Greptile |
Member
|
What's the point of changing add method stuffs |
Author
|
@bajrangCoder sometimes when I make plugins, we can add a selectionMenu but we cannot remove it. so what if the add method return the menuItem and that menuItem can be used to remove the selectionMenu from items? Sorry if my English is bad, I'm using a translate app |
vikramgaming
force-pushed
the
selectionMenu
branch
from
August 17, 2026 23:46
bae2542 to
e3c4819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.