Skip to content

added remove method for selectionMenu, add method now return an item #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikramgaming wants to merge 2 commits into
base: main
Choose a base branch
from
+63 −56
Open

added remove method for selectionMenu, add method now return an item #2761

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c11ab1
added remove method for selectionMenu, add method now return an item
vikramgaming Aug 17, 2026
e3c4819
just formatting the code
vikramgaming Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 63 additions & 56 deletions src/lib/selectionMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,70 +1,70 @@
import { focusEditorIfEditable } from "cm/editorReadOnly";

Check failure on line 1 in src/lib/selectionMenu.js

View workflow job for this annotation

GitHub Actions / Linting and formatting

format 

File content differs from formatting output
import appSettings from "lib/settings";

const exec = (command) => {
const { editor } = editorManager;
editor.execCommand(command);
const { editor } = editorManager;
editor.execCommand(command);

if (command === "selectall") {
editor.scrollToRow(Number.POSITIVE_INFINITY);
editor.setSelection(true);
editor.setMenu(true);
}
focusEditorIfEditable(editor);
if (command === "selectall") {
editor.scrollToRow(Number.POSITIVE_INFINITY);
editor.setSelection(true);
editor.setMenu(true);
}
focusEditorIfEditable(editor);
};

const showCodeActions = async () => {
const { editor } = editorManager;
if (!editor) return;
const { editor } = editorManager;
if (!editor) return;

try {
const { showCodeActionsMenu, supportsCodeActions } = await import("cm/lsp");
if (supportsCodeActions(editor)) {
await showCodeActionsMenu(editor);
}
} catch (error) {
console.warn("[SelectionMenu] Code actions not available:", error);
}
try {
const { showCodeActionsMenu, supportsCodeActions } = await import("cm/lsp");
if (supportsCodeActions(editor)) {
await showCodeActionsMenu(editor);
}
} catch (error) {
console.warn("[SelectionMenu] Code actions not available:", error);
}
};

const items = [];

export default function selectionMenu() {
return [
item(
() => exec("copy"),
<span className="icon copy"></span>,
"selected",
true,
),
item(() => exec("cut"), <span className="icon cut"></span>, "selected"),
item(() => exec("paste"), <span className="icon paste"></span>, "all"),
item(
() => exec("selectall"),
<span className="icon text_format"></span>,
"all",
true,
),
appSettings.get("showShareButton") &&
item(
() => exec("share"),
<span className="icon share"></span>,
"selected",
true,
),
item(
(color) => acode.exec("insert-color", color),
<span className="icon color_lenspalette"></span>,
"all",
),
item(
() => showCodeActions(),
<span className="icon lightbulb" title="Code Actions"></span>,
"all",
true,
),
...items,
].filter(Boolean);
return [
item(
() => exec("copy"),
<span className="icon copy"></span>,
"selected",
true,
),
item(() => exec("cut"), <span className="icon cut"></span>, "selected"),
item(() => exec("paste"), <span className="icon paste"></span>, "all"),
item(
() => exec("selectall"),
<span className="icon text_format"></span>,
"all",
true,
),
appSettings.get("showShareButton") &&
item(
() => exec("share"),
<span className="icon share"></span>,
"selected",
true,
),
item(
(color) => acode.exec("insert-color", color),
<span className="icon color_lenspalette"></span>,
"all",
),
item(
() => showCodeActions(),
<span className="icon lightbulb" title="Code Actions"></span>,
"all",
true,
),
...items,
].filter(Boolean);
}

/**
Expand All @@ -75,13 +75,20 @@
* @param {boolean} readOnly whether to show the item in readOnly mode
*/
selectionMenu.add = (onclick, text, mode, readOnly) => {
items.push(item(onclick, text, mode, readOnly));
const menuItem = item(onclick, text, mode, readOnly);
items.push(menuItem);
return menuItem;
};

selectionMenu.remove = (item) => {
const i = items.indexOf(item);
if (i >= 0) items.splice(i, 1);
};

selectionMenu.exec = (command) => {
exec(command);
exec(command);
};

function item(onclick, text, mode = "all", readOnly = false) {
return { onclick, text, mode, readOnly };
return { onclick, text, mode, readOnly };
}
Loading