Repository navigation
Configure Functions Worker SDK as analyzer-only dependency - #76
Conversation
Bumps Microsoft.Azure.Functions.Worker.Sdk from 2.0.7 to 2.1.0 Bumps Microsoft.Extensions.Logging.Abstractions from 10.0.10 to 10.0.11 Bumps Microsoft.Extensions.Options.DataAnnotations from 10.0.10 to 10.0.11 Bumps Microsoft.NET.Test.Sdk from 18.8.1 to 18.9.0 Bumps MSTest from 4.3.2 to 4.4.0 --- updated-dependencies: - dependency-name: Microsoft.Azure.Functions.Worker.Sdk dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-minor-patch - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-minor-patch - dependency-name: Microsoft.Extensions.Options.DataAnnotations dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-minor-patch - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-minor-patch - dependency-name: MSTest dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-minor-patch group (#67) * Chore(deps): bump actions/checkout in the actions-minor-patch group Bumps the actions-minor-patch group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 7.0.0 to 7.0.1 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@9c091bb...3d3c42e) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix YAML indentation: indent steps list items under steps: in ci.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Burg <david.burg@microsoft.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
David Burg (daviburg)
left a comment
David Burg (daviburg)
left a comment
There was a problem hiding this comment.
Copilot the PR has no change. Please explain.
This PR is empty because the requested work was to file a separate backlog issue, not modify the dependency-maintenance change. I could not create that issue because this session has no issue-creation capability; I should have explained that before leaving this PR open. The original branch’s CI is passing (79 tests, 0 build errors). |
* Document CI merge gate * Describe samples CI validation * Correct samples CI validation description * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: David Burg <12040431+daviburg@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Copilot can you address the original issue directly then, re-targeting this PR to main branch instead? |
…eedback-dependency-maintenance-pr Co-authored-by: daviburg <12040431+daviburg@users.noreply.github.com>
Co-authored-by: daviburg <12040431+daviburg@users.noreply.github.com>
Implemented the original Worker SDK package-reference fix in d4103d6 and merged the current |
David Burg (daviburg)
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
Only minor, non-blocking checkout-version documentation nits remain.
Pull request overview
Configures the Azure Functions Worker SDK as an analyzer-only dependency and documents CI validation.
Changes:
- Adds analyzer-only and private asset metadata.
- Documents required validation checks.
- Updates CI checkout references and formatting.
File summaries
| File | Summary |
|---|---|
DirectConnector/DirectConnector.csproj |
Configures Worker SDK dependency metadata. |
CONTRIBUTING.md |
Documents automated PR validation. |
.github/workflows/ci.yml |
Updates workflow formatting and checkout references. |
Review details
Suppressed comments (2)
.github/workflows/ci.yml:14
- This follow-up is described as only adding analyzer/private-asset metadata to the Worker SDK, but this hunk also upgrades
actions/checkoutfrom v7.0.0 to v7.0.1; the same unrelated update appears in the matrix job at line 38. PR #75's dependency diff did not contain this workflow change, so please revert both action-reference changes or document them as an intentional part of this PR.
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
.github/workflows/ci.yml:38
- The matrix job repeats an
actions/checkoutupgrade that is unrelated to the stated SDK metadata change; PR #75's dependency diff did not include this workflow update. Please revert both v7.0.1 references or document the workflow dependency change in this PR description.
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
PR #79 replaces this PR with the same analyzer-only package-reference fix on a clean branch based directly on GitHub created #76 as part of stack #77 and rejects base-branch changes for stack entries through both GraphQL and REST, including while the PR is closed. Closing this PR avoids carrying the unrelated parent dependency diff; review should continue on #79. |
Summary
Configure
Microsoft.Azure.Functions.Worker.Sdkas an analyzer-only build dependency by addingOutputItemType="Analyzer"andPrivateAssets="all".This follows up on the Copilot review finding from #75 without changing that dependency-maintenance PR.
Validation
dotnet test Connectors-NET-Samples.sln --configuration Release --no-restoreRelated review: #75 (comment)