Configure Functions Worker SDK as analyzer-only dependency - #79
Open
David Burg (daviburg) wants to merge 1 commit into
Open
David Burg (daviburg) wants to merge 1 commit into
David Burg (daviburg) wants to merge 1 commit into
Conversation
Co-authored-by: Dobby <dobby@microsoft.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Configures the Azure Functions Worker SDK as an analyzer-only build dependency.
Changes:
- Adds
OutputItemType="Analyzer"andPrivateAssets="all".
File summaries
| File | Description |
|---|---|
DirectConnector/DirectConnector.csproj |
Updates Worker SDK dependency metadata. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configure
Microsoft.Azure.Functions.Worker.Sdkas an analyzer-only build dependency by addingOutputItemType="Analyzer"andPrivateAssets="all".This follows up on the Copilot review finding from #75 without changing that dependency-maintenance PR. It replaces #76 because GitHub created that PR as part of an immutable stack and would not allow its base branch to be changed to
mainthrough either GraphQL or REST.Validation
dotnet test Connectors-NET-Samples.sln --configuration Release --no-restoresucceeded on the original fix branch (79 tests passed, 0 build errors)OutputItemType=AnalyzerandPrivateAssets=allgit diff --checkpassesA fresh local restore is currently blocked by a TLS handshake failure reaching
https://api.nuget.org/v3/index.json; GitHub CI provides the authoritative clean restore and test validation.Related review: #75 (comment)
Supersedes: #76