Skip to content

make popup banner more flexible#914

Merged
kjaymiller merged 4 commits into
gh-pagesfrom
change-popup-banner
May 22, 2026
Merged

make popup banner more flexible#914
kjaymiller merged 4 commits into
gh-pagesfrom
change-popup-banner

Conversation

@kjaymiller
Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

Converts

  • What: Provide an overview of the issue this PR addresses. Explain the context and background information.

  • Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.

  • How: Explain how these changes will affect the project or end-users.

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

Add any additional notes or comments that might be helpful for the reviewers.

@kjaymiller kjaymiller requested review from dragid10 and lazouich May 21, 2026 15:31
kjaymiller and others added 2 commits May 22, 2026 09:26
* update render-engine and adopt RedirectPage

Bumps render-engine to 2026.5.2a1 and switches the five redirect pages
(students, community, partnerships, leadership, pycon) to use the new
RedirectPage class from render-engine/render-engine#1161 instead of
hand-written meta-refresh HTML.

Also fixes the students slug, which previously redirected to the
non-existent /student-ambassadors-program.html.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* remove unused hand-written redirect HTML

These five files were the meta-refresh source for redirects now handled
by RedirectPage in app.py — they were never referenced via content_path
after the switch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* lock

* update broken links

* Update pyproject.toml

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* Update app.py

Co-authored-by: Alex Oladele <dragid10@gmail.com>

* versions

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Alex Oladele <dragid10@gmail.com>
@kjaymiller kjaymiller merged commit d473205 into gh-pages May 22, 2026
6 checks passed
@kjaymiller kjaymiller deleted the change-popup-banner branch May 22, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants