Repository navigation
fix(openvas): retain scanner-reported IP address and remove dead hostname branch - #16734
Open
happymode-25 wants to merge 1 commit into
Open
happymode-25 wants to merge 1 commit into
happymode-25 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #16002
This PR addresses the issue where the OpenVAS parser dropped scanner-reported IP addresses when hostnames were present, and reconciles the parsing behavior between v1 and v2.
Changes
dojo/tools/openvas/parser_v1/xml_parser.py:if field.tag == 'hostname':dead code (in Greenbone/OpenVAS XML output,<hostname>is always nested inside<host>, never a direct child of<result>).<hostname>from<host>when present and append**Hostname**: <name>to finding description.dojo/tools/openvas/parser_v2/xml_parser.py&csv_parser.py:ip_addressandhostnameinaux_info.postprocess_finding(common.py), if bothip_addressandhostnameare present and distinct, append**IP Address**: <ip>to finding description so scanner-reported IP addresses are never lost.unittests/tools/test_openvas_parser.py: