Make the Data panel able to display data from selected nodes living in subgraphs#4064
Merged
Make the Data panel able to display data from selected nodes living in subgraphs#4064
Conversation
Keavon
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the node inspection system from using single node IDs to full node paths, enabling the Data panel to introspect nodes within nested subnetworks. The changes involve updating the message handlers, portfolio logic, and the graph executor to propagate and handle these paths, allowing monitor nodes to be correctly spliced into subgraphs. Feedback suggests optimizing the access method in the runtime by pre-calculating paths to avoid redundant allocations and cloning during execution.
Keavon
force-pushed
the
data-panel-for-nested-graphs
branch
from
1c00290 to
073ddf4
Compare
Keavon
force-pushed
the
data-panel-for-nested-graphs
branch
from
073ddf4 to
6beb58b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #3779.