Centralize attribute strings in consts and rename "editor:layer" to "editor:layer_path"#4076
Merged
Centralize attribute strings in consts and rename "editor:layer" to "editor:layer_path"#4076
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to use centralized constants for attribute keys (e.g., ATTR_TRANSFORM, ATTR_EDITOR_LAYER_PATH, ATTR_ALPHA_BLENDING) instead of hardcoded string literals throughout the node graph and rendering logic. This improves maintainability and reduces the risk of typos when accessing these attributes. I have no further feedback to provide.
Keavon
added a commit
that referenced
this pull request
Apr 29, 2026
…editor:layer_path" (#4076) * Rename "editor:layer" to "editor:layer_path" and centralize it in a const * Centralize "editor:merged_layers" in a const * Centralize all other attributes in consts * Rename consts with ATTR_ prefix * Format
oluseyi
pushed a commit
to oluseyi/Graphite
that referenced
this pull request
Apr 29, 2026
…editor:layer_path" (GraphiteEditor#4076) * Rename "editor:layer" to "editor:layer_path" and centralize it in a const * Centralize "editor:merged_layers" in a const * Centralize all other attributes in consts * Rename consts with ATTR_ prefix * Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #3779.