feat(agent-applications): session search matches conversation text - #2895
Merged
Conversation
With the backend search_text digest landing (PostHog/posthog#65764), the sessions search now matches transcript text — restore the placeholder to "Search conversations…" and update the param doc (both were narrowed to "id or external key" while transcript search was deferred for scale). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(agent-applications): session search..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+106
to
107
| placeholder="Search conversations…" | ||
| aria-label="Search sessions" |
Contributor
There was a problem hiding this comment.
aria-label still reads "Search sessions", making the two inconsistent for screen reader users. Aligning them keeps the accessible label in sync with the visible copy.
Suggested change
| placeholder="Search conversations…" | |
| aria-label="Search sessions" | |
| placeholder="Search conversations…" | |
| aria-label="Search conversations" |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
benjackwhite
marked this pull request as ready for review
June 24, 2026 12:08
dmarticus
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend counterpart to PostHog/posthog#65764 (the persisted
search_textdigest that makes session search cover transcripts).The session search box already sends
?search=; that PR makes the backend match the conversation text (not just id / external_key). This aligns the UI copy:Search by id or external key…→Search conversations…AgentSessionsListParams.searchdoc updated to mention the conversation text.No behaviour change on this side — purely the copy/doc that was narrowed when transcript search was deferred for scale. Merge alongside (or after) #65764.
🤖 Generated with Claude Code