Skip to content

feat(agent-applications): session search matches conversation text #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjackwhite merged 1 commit into from
Jun 25, 2026
Merged

feat(agent-applications): session search matches conversation text #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/src/agent-platform-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ export interface AgentSessionsListParams {
agent_user_id?: string;
created_after?: string;
created_before?: string;
/** Case-insensitive server-side match over the session id and external key. */
/** Case-insensitive server-side match over the conversation text, id, and external key. */
search?: string;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/features/agent-applications/components/AgentSessionsPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function AgentSessionsPane({ idOrSlug }: { idOrSlug: string }) {
type="search"
value={queryInput}
onChange={(e) => changeQuery(e.currentTarget.value)}
placeholder="Search by id or external key…"
placeholder="Search conversations…"
aria-label="Search sessions"
Comment on lines +106 to 107

@greptile-apps greptile-apps Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The placeholder was updated to "Search conversations…" but the aria-label still reads "Search sessions", making the two inconsistent for screen reader users. Aligning them keeps the accessible label in sync with the visible copy.

Suggested change
placeholder="Search conversations…"
aria-label="Search sessions"
placeholder="Search conversations…"
aria-label="Search conversations"

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

className="h-8 w-full rounded-(--radius-2) border border-border bg-(--color-panel-solid) pr-2 pl-8 text-[12.5px]"
/>
Expand Down
Loading