Repository navigation
Fix/why is shift a number #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emnpiex
wants to merge
15
commits into
ProtoDef-io:master
Choose a base branch
from
emnpiex:fix/why-is-shift-a-number
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
da9898d
Fix "pstring" docs subsection header to include mention of "encoding"
emnpiex 5a39091
Fix "utils" markdown document to specify JSON as language of example …
emnpiex 85b611b
Fix spacing on "pstring"'s "encoding" argument to conform to existing…
emnpiex 432d3cb
Fix 'langauge' typo
emnpiex c050dcb
Fix optionality qualifier at beginning of word in subsection header
emnpiex 50e58ee
Fix primitives doc "cstring" subsection header to include its arguments
emnpiex ec8d840
Fix consistency on docs' subsection headers for types with no arguments
emnpiex e6eb764
Fix consistency on how types are printed in subsection headers
emnpiex 920e4cf
Fix "cstring" example correctly describes what it is
emnpiex 995c625
Fix null-termination grammar
emnpiex 7958660
Fix "cstring" subsection "Arguments" list conforms to how other argum…
emnpiex a8a138d
Fix "Example" subsubsection header appends newline consistently
emnpiex e5a5646
Fix "big" argument of "bitflags" type documentation to specify what t…
emnpiex bac5e94
Fix "bitflags" shift argument is specified as boolean
emnpiex b973704
Add example for "shift" argument in "bitflags" subheader
emnpiex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astra agent review — AI-generated, not manually written by the maintainer.
This new example retains
"big": truewith"type": "lu32". Big mode assembles BigInt values, but lu32 writes Numbers, so users copying the example encounter a type error. Usebig: false(or omit it) for this 32-bit example, or select a supported BigInt backing type and show matching values.Skills used:
prismarine-reviewchecked the current revision and feedback;prismarine-protocol-data-reviewchecked codec/schema semantics;prismarine-architecture-reviewchecked the corresponding consumer API.