Repository navigation
Conversation
…JSON code-block - modifies language used to indicate what the numerals are
…ents are presented
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The boolean shift description matches the implementation's position-versus-mask selector. Before landing this documentation stack, make the newly added shifted example executable with its chosen numeric type; it currently combines BigInt assembly with lu32's Number writer. Coordinate that correction with #64.
This is a documentation/codec-contract review; no fresh full suite was run.
Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.
| { | ||
| "type": "lu32", | ||
| "big": true, | ||
| "shift": true, |
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
This new example retains "big": true with "type": "lu32". Big mode assembles BigInt values, but lu32 writes Numbers, so users copying the example encounter a type error. Use big: false (or omit it) for this 32-bit example, or select a supported BigInt backing type and show matching values.
Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.
note: PR based on #57
depends on #58 for whether you want this merged.