Repository navigation
Conversation
…JSON code-block - modifies language used to indicate what the numerals are
…ents are presented
- "flags" property's "object" alternative is overly permissive
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The stricter bitflags schema currently contains an invalid JSON Schema property definition. Repair that before landing the stack, and keep the new examples compatible with their numeric backing type (big: true cannot feed lu32's Number writer).
The boolean shift clarification from #59 is consistent with runtime behavior, but neither that documentation nor the inherited cleanup makes the new schema valid. Static schema/runtime review only.
Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "type": "string", |
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Within properties, each value must itself be a schema; the literal string here is invalid. Use "type": { "type": "string" } (or the appropriate shared type reference), then meta-validate this schema and exercise a valid/invalid bitflags definition through the actual validator. Otherwise schema compilation can fail before user data is checked.
Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.
note: PR based on #59
less permissive schema for "bitflags" type