fix: Improve keyboard accessibility of slider field#2727
Open
gonfunko wants to merge 1 commit into
Open
Conversation
maribethb
reviewed
Jun 26, 2026
| handled = true; | ||
| } | ||
|
|
||
| if (handled) { |
Contributor
There was a problem hiding this comment.
Does this handle firing the final block change event too? I expected there to be more to do about setting the final value
Contributor
Author
There was a problem hiding this comment.
Yep, the superclass' widgetDispose_ handler takes care of that when it's automatically invoked by the WidgetDiv being dismissed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR improves the keyboard accessibility of the slider field. Specifically, it: