Skip to content

fix: Improve keyboard accessibility of slider field #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 1 commit into from
Jun 29, 2026
Merged

fix: Improve keyboard accessibility of slider field #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions plugins/field-slider/src/field_slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,13 @@ export class FieldSlider extends Blockly.FieldNumber {

// Focus on the slider field, unless quietInput is passed.
if (!quietInput) {
(editor.firstChild as HTMLInputElement).focus({
preventScroll: true,
});
// Wait for the dropdown to animate in before attempting to focus the
// slider.
setTimeout(() => {
this.sliderInput?.focus({
preventScroll: true,
});
}, 250);
}
}

Expand All @@ -153,7 +157,27 @@ export class FieldSlider extends Blockly.FieldNumber {
sliderInput.setAttribute('step', `${this.precision_}`);
sliderInput.setAttribute('value', `${this.getValue()}`);
sliderInput.setAttribute('tabindex', '0');
sliderInput.setAttribute('data-untyped-default-value', String(this.value_));
sliderInput.className = 'fieldSlider';
sliderInput.addEventListener('keydown', (e) => {
let handled = false;
if (e.key === 'Enter') {
handled = true;
} else if (e.key === 'Escape') {
this.isBeingEdited_ = false;
this.setValue(
sliderInput.getAttribute('data-untyped-default-value'),
false,
);
handled = true;
}

if (handled) {
Comment thread
gonfunko marked this conversation as resolved.
Blockly.WidgetDiv.hideIfOwner(this);
Blockly.DropDownDiv.hideIfOwner(this);
e.stopPropagation();
}
});
wrapper.appendChild(sliderInput);
this.sliderInput = sliderInput;

Expand Down
Loading