Quit the driver when logging in fails in the test fixture - #1539
Merged
Conversation
Closes #1497 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM
adamtheturtle
force-pushed
the
adamtheturtle/vws-web-tools-issue-1497
branch
from
August 27, 2026 08:05
50f03d5 to
92dbdf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1497.
fixture_logged_in_chrome_drivercreated a driver, logged in, and quit it in the code afteryield. Everything afteryieldin a generator fixture is tear down, and tear down does not run for a fixture that raised before yielding — so whenlog_infails, the browser and the ChromeDriver service it started are never stopped.log_inis wrapped in the tenacity retry, so the failure mode this hits is exactly a login that has retried five times and given up: it leaks a Chrome and a chromedriver, and because the fixture is module-scoped it does that once per module.Selenium's
WebDriveris already a context manager whose__exit__callsquit(), so movinglog_inand theyieldinsidewith vws_web_tools.create_chrome_driver() as driver:guarantees cleanup on that path without adding any API.fixture_chrome_drivergets the same shape for consistency, though it was never at risk — it yields immediately.On the library side there is nothing to fix here:
log_indoes not create a driver, so its retries cannot leak one, and every CLI command already quits in afinally.🤖 Generated with Claude Code
https://claude.ai/code/session_01YJDy3qA1LyNTh11zS98ukM