Skip to content

Quit the driver when logging in fails in the test fixture #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Aug 27, 2026
Merged

Quit the driver when logging in fails in the test fixture #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions tests/test_create_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,27 @@
@pytest.fixture(name="chrome_driver")
def fixture_chrome_driver() -> Iterator[WebDriver]:
"""Yield a headless Chrome WebDriver, quitting on tear down."""
driver = vws_web_tools.create_chrome_driver()
yield driver
driver.quit()
with vws_web_tools.create_chrome_driver() as driver:
yield driver


@pytest.fixture(name="logged_in_chrome_driver", scope="module")
def fixture_logged_in_chrome_driver(
vws_credentials: VWSCredentials,
) -> Iterator[WebDriver]:
"""Yield a headless Chrome WebDriver that is logged in."""
driver = vws_web_tools.create_chrome_driver()
vws_web_tools.log_in(
driver=driver,
email_address=vws_credentials.email_address,
password=vws_credentials.password,
)
yield driver
driver.quit()
"""Yield a headless Chrome WebDriver that is logged in.

Logging in happens inside the ``with`` block so that the browser and
the ChromeDriver service are stopped even if logging in fails, when
the tear down after the ``yield`` never runs.
"""
with vws_web_tools.create_chrome_driver() as driver:
vws_web_tools.log_in(
driver=driver,
email_address=vws_credentials.email_address,
password=vws_credentials.password,
)
yield driver


@pytest.fixture(name="license_name", scope="module")
Expand Down